-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment variable interface #3568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
Just one comment, it should be fine to keep it unchanged.
paddle/platform/gpu_info.h
Outdated
|
||
namespace paddle { | ||
namespace platform { | ||
|
||
//! Environment variable: fraction of GPU memory to use on each device. | ||
const std::string kEnvFractionGpuMemoryToUse = "FRACTION_GPU_MEMORY_TO_USE"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Environment variable often have prefix to distinguash between applications, to prevent if two application use the same name. Maybe start with "PADDLE_"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great! Thanks.
* fix bs=2 of FCOS * fix bs=2 of ttfnet * fix cascade deploy * speedup by paddle.expand
Then, run
ctest -V -R memory_test
fix #3437