Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kunlun]fix multi xpu dygraph hang, test=kunlun #32662

Merged
merged 3 commits into from
Apr 29, 2021
Merged

[Kunlun]fix multi xpu dygraph hang, test=kunlun #32662

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3ce963
fix multi xpu dygraph hang, test=kunlun
vslyu Apr 28, 2021
4145f5f
fix multi xpu dygraph hang, test=kunlun
vslyu Apr 29, 2021
8f7de1d
fix multi xpu dygraph hang, test=kunlun
vslyu Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions paddle/fluid/imperative/reducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,10 +762,11 @@ void Reducer::MarkGroupReady(size_t group_index) {
// TODO(liuyuhui): Add try catch to deal with exception later,
// otherwise the main thread will continue to run when an exception is
// thrown in comm_pool_.
comm_pool_->enqueue([&] {
auto next_group = next_group_;
comm_pool_->enqueue([&, run_order, next_group] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this, run_order, next_group, &group
明确到各个变量，不要直接用一个&

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

auto dev_id = BOOST_GET_CONST(platform::XPUPlace, place_).device;
platform::SetXPUDeviceId(dev_id);
FusedAllReduceSchedule(run_order, group, next_group_);
FusedAllReduceSchedule(run_order, group, next_group);
{
std::lock_guard<std::mutex> lock(mutex_);
comm_op_count_ -= 1; // lock
Expand Down