-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BF16 uniform random initializer #32468
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Please just take into account my one comment.
@luotao1 Could you please start your review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please cherry-pick into release/2.1 |
* Add bf16 uniform random initializer * Remove duplicated section * Change UT to CPU place only * Put detail functions into anonymous namespace
PR types
New features
PR changes
OPs
Describe
This PR adds support for the BF16 datatype for the uniform_random operator.
Therefore, in the initializers that I use uniform_random_op, i.e. Uniform, Xavier (uniform) and MSRA (uniform), it will not be necessary to add the cast operators before and after the initializer if the input is BF16, which was changed in the file `initalizer.py