[ROCM] update fluid platform for rocm35 (part1), test=develop #30639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
qili93
force-pushed
the
rocm_platform_part1
branch
from
38f330b to
b708405
Compare
qili93
force-pushed
the
rocm_platform_part1
branch
from
2a5a3e6 to
50b5659
Compare
qili93
force-pushed
the
rocm_platform_part1
branch
from
50b5659 to
6710055
Compare
chenwhql
previously approved these changes
Jan 26, 2021
|
|
||
| inline const char* rocblasGetErrorString(rocblas_status stat) { | ||
| switch (stat) { | ||
| case rocblas_status_invalid_handle: |
There was a problem hiding this comment.
用户反馈我们第三方库报错只有一个status，没说具体原因，然后在搜索引擎又不能比较快的找到官网解释的话，用户体验会比较差，这块 @zhouwei25 后续还会做一些增强，可以关注下
zhwesky2010
reviewed
Jan 26, 2021
paddle/fluid/platform/enforce.h
Outdated
| return webstr.str(); | ||
| } | ||
|
|
||
| inline std::string build_nvidia_error_msg(hipError_t e) { |
There was a problem hiding this comment.
这是Nvidia 5种类型的报错统一接口，是将官网信息映射为 报错码+报错内容 的形式压缩到一个cudaerrormessage.pb的文件里去，AMD GPU的报错信息可以叫build_amd_error_msg，现在那个cudaerrormessage.pb只有Nvidia的部分，没有AMD的，可以先不走这块查询逻辑，因为肯定查不到。
There was a problem hiding this comment.
改成build_rocm_error_msg
paddle/fluid/platform/enforce.h
Outdated
| /***** HIP ERROR *****/ | ||
| inline bool is_error(hipError_t e) { return e != hipSuccess; } | ||
|
|
||
| inline std::string GetCudaErrorWebsite(int32_t cuda_version) { |
There was a problem hiding this comment.
去掉了GetCudaErrorWebsite
zhwesky2010
reviewed
Jan 26, 2021
| int32_t cuda_version = -1; | ||
| #endif | ||
| std::ostringstream sout; | ||
| sout << " Hip error(" << e << "), " << hipGetErrorString(e) << "."; |
There was a problem hiding this comment.
先打出hipGetErrorString(e)这部分，后面的逻辑目前无法触发可以先不用写
There was a problem hiding this comment.
删除了hipGetErrorString(e)之后的error string的逻辑
chenwhql
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Update paddle fluid platform for rocm35 - part1