Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dim::contiguous and Dim::contiguous_strides #2813

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Remove Dim::contiguous and Dim::contiguous_strides #2813

merged 1 commit into from
Jul 12, 2017

Conversation

JiayiFeng
Copy link
Collaborator

Paddle's data block is row-major order, while Dim::contiguous and Dim::contiguous_strides are based on column-order. So remove them to prevent misuse.

@JiayiFeng
Remove Dim::contiguous and Dim::contiguous_strides
2dbe60e 
Paddle's data block is row-major order, while Dim::contiguous and
Dim::contiguous_strides are based on column-order. So remove them to
prevent misuse.
@JiayiFeng JiayiFeng requested a review from QiJune July 12, 2017 03:22
QiJune
QiJune approved these changes Jul 12, 2017
View reviewed changes
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiayiFeng JiayiFeng merged commit 8681c58 into PaddlePaddle:develop Jul 12, 2017
@JiayiFeng JiayiFeng deleted the dev_update_dim branch July 12, 2017 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QiJune QiJune QiJune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiayiFeng @QiJune