Fix slow parsing a recursive depends topology #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Jul 11, 2017
| @@ -1419,6 +1421,11 @@ def __dfs_travel__(layer, | |||
| :type layer: LayerOutput | |||
| :return: | |||
| """ | |||
| if layer in traveled: | |||
There was a problem hiding this comment.
seems this bug has no relation with v2 api？
* Fix PaddlePaddle#2797 * It because trainer_config_helpers' __dfs_travel__ did not record the node which travelled, and if the topology has a recursive dependency, there are some nodes will be travelled multiple times. * Add a `travelled` set to record which node is travelled. * Also add a unittest for this situation.
reyoung
force-pushed
the
feature/fix_python_slow
branch
from
4dfc779
to
313e9f5
Compare
jacquesqiao
reviewed
Jul 11, 2017
| @@ -0,0 +1,497 @@ | |||
| type: "nn" | |||
There was a problem hiding this comment.
will this file be used any where?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node which travelled, and if the topology has a recursive dependency,
there are some nodes will be travelled multiple times.
travelledset to record which node is travelled.