Expose paddle.framework by pybind11 #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
reyoung
commented
Jul 10, 2017
reyoung
commented
- Export paddle.framework.{Scope, Variable} to paddle.v2.framework.core.
- See python/paddle/v2/framework/tests/test_scope.py for Python usage
- See paddle/pybind/pybind.cc for C++ bind code.
reyoung
force-pushed
the
feature/pybind11_api
branch
from
f3c4aa0
to
2ab9166
Compare
* Export paddle.framework.{Scope, Variable} to paddle.v2.framework.core.
* See python/paddle/v2/framework/tests/test_scope.py for Python usage
* See paddle/pybind/pybind.cc for C++ bind code.
reyoung
force-pushed
the
feature/pybind11_api
branch
from
2ab9166
to
f379fb5
Compare
jacquesqiao
reviewed
Jul 11, 2017
| @@ -0,0 +1,32 @@ | |||
| #include <paddle/framework/scope.h> | |||
|
如果现在这样默认编译到paddle的whl包中，我们自己编译安装会因为python的兼容性问题导致无法使用么？如果有兼容性问题，感觉需要加一个开关。 If pybind has the compatibility problem with python now? If so, we may need to add a switch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.