Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Sampler/SequenceSampler/RandomSampler #26375

Merged
merged 4 commits into from
Aug 19, 2020
Merged

add Sampler/SequenceSampler/RandomSampler #26375

merged 4 commits into from
Aug 19, 2020

Conversation

heavengate
Copy link
Contributor

@heavengate heavengate commented Aug 17, 2020 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

  • add base class paddle.io.Sampler
  • add paddle.io.SequenceSampler
  • add paddle.io.RandomSampler
  • change paddle.io.BatchSampler parameter indices to sampler

sampler1
sampler2
sequence_sampler
random_sampler

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

LielinJiang
LielinJiang previously approved these changes Aug 18, 2020
View reviewed changes
qingqing01
qingqing01 reviewed Aug 18, 2020
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/paddle/fluid/dataloader/sampler.py Outdated

Args:
data_source(Dataset): dataset to sample, this could be an
instance of :code:`paddle.io.Dataset` other python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python -> Python

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@heavengate heavengate changed the title add Sampler/SequenceSampler/RandomSampler. test=develop add Sampler/SequenceSampler/RandomSampler Aug 19, 2020
@heavengate heavengate merged commit c45481d into PaddlePaddle:develop Aug 19, 2020
@heavengate heavengate deleted the add_sampler branch August 19, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LielinJiang LielinJiang LielinJiang approved these changes

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heavengate @qingqing01 @LielinJiang