Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify pipeline optimizer to only support the mode of sync pipeline training #25065

Merged
merged 18 commits into from
Jul 3, 2020
Merged

modify pipeline optimizer to only support the mode of sync pipeline training #25065

merged 18 commits into from
Jul 3, 2020

Conversation

sandyhouse
Copy link

PR types

New features

PR changes

Others

Describe

modify pipeline optimizer to only support the mode of sync pipeline training

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

guru4elephant
guru4elephant requested changes Jun 19, 2020
View reviewed changes
python/paddle/fluid/optimizer.py Outdated Show resolved Hide resolved
@paddle-bot-old
Copy link

Thanks for your contribution!
Please add test = develop in your commit message to trigger CI to ensure your PR can be merged.
See Paddle CI Manual for details.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please add test = develop in your commit message to trigger CI to ensure your PR can be merged.
See Paddle CI Manual for details.

gavin1332
gavin1332 previously approved these changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@gavin1332 gavin1332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kolinwei
kolinwei previously approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@kolinwei kolinwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PipelineOptimizer进行了重构，源单测删掉，PR中有其他单测进行了补充，先approve，看看覆盖率是否能达标

Heeenrrry
Heeenrrry previously approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@Heeenrrry Heeenrrry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit reviewed Jul 2, 2020
View reviewed changes
python/paddle/fluid/optimizer.py Outdated Show resolved Hide resolved
python/paddle/fluid/optimizer.py Show resolved Hide resolved
python/paddle/fluid/optimizer.py Show resolved Hide resolved
@sandyhouse sandyhouse dismissed stale reviews from Heeenrrry, kolinwei, and gavin1332 via 99c4c03 July 2, 2020 08:19
XiaoguangHu01
XiaoguangHu01 approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API

Heeenrrry
Heeenrrry approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@Heeenrrry Heeenrrry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gavin1332
gavin1332 approved these changes Jul 3, 2020
View reviewed changes
Copy link
Collaborator

@gavin1332 gavin1332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

guru4elephant
guru4elephant approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@guru4elephant guru4elephant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Currently, a user has to define device guard to use pipeline parallelism. An automatic way to allocate device guard is needed in the following PRs.

@guru4elephant guru4elephant merged commit 3d96601 into PaddlePaddle:develop Jul 3, 2020
@sandyhouse sandyhouse deleted the pipeline_optimize branch April 25, 2021 13:34
@SigureMo SigureMo mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@guru4elephant guru4elephant guru4elephant approved these changes

@Heeenrrry Heeenrrry Heeenrrry approved these changes

@kolinwei kolinwei kolinwei approved these changes

@gavin1332 gavin1332 gavin1332 approved these changes

@lanxianghit lanxianghit Awaiting requested review from lanxianghit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sandyhouse @gavin1332 @kolinwei @Heeenrrry @guru4elephant @XiaoguangHu01 @lanxianghit