Add macro BOOST_GET to enrich the error information of boost :: get #24175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlrain
reviewed
Apr 27, 2020
paddle/fluid/platform/enforce.h
Outdated
| "(%s) by type %s, its type is %s.", \ | ||
| #__VALUE, paddle::platform::demangle(typeid(__TYPE).name()), \ | ||
| paddle::platform::demangle(__VALUE.type().name()))); \ | ||
| } \ |
There was a problem hiding this comment.
这个boost::get 除了 bad_get 还有其他情况的异常么， 需要不要 catch(...) 捕获其他的异常
There was a problem hiding this comment.
仅会抛出bad_get异常
看了下源码：https://www.boost.org/doc/libs/1_58_0/boost/variant/get.hpp
里面如果get失败，一律抛出bad_get
chenwhql
changed the title
lanxianghit
approved these changes
May 9, 2020
raindrops2sea
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost::getis not a completely safe interface, although it will not go wrong in most cases, but in extreme case, if may fail and directly throw aboost::bad_getexception without any stack information. This kind of problem is difficult to debug.Related issues:
Now there are nearly 600
boost :: getin paddle without catch exception when used.In this PR, I add new series macros
BOOST_GET{***}, It encapsulatesboost :: getas follows:Use this macro instead of
boost :: get, when something goes wrong, we can get richer error information . Including the error file, line number, expected value type and actual value type, this can help users to locate the cause of the error easily.difficulty
The
boost :: gethas 4 types of return value, includeT, const T, T&, const T&, so here need some tricks to cover these 4 scenarios with only one macro. With the help of @sneaxiy, under the gcc5.4 environment, we solved this problem with only one macro, see the commit 11bbbb2.But CI now using gcc4.8, the writing above cannot be compiled under gcc4.8, this is a gcc4.8’s bug, gcc official recommends to use a higher version to solve. So I had to write three macros here to solve this problem, as follows:
Examples:
Case 1: Place Get Error
1. original
boost::getthis is a C++ exception, but using
boost::getdirectly cannot throw C++ error info.code piece
2. new macro
BOOST_GETCase 2: Attr Get Error
1. original
boost::get2. new macro
BOOST_GETCI check
In order to avoid the direct use of
boost :: get, I added a new rule to CI to limit the use ofboost :: get. If found, it will remind developer to use the macroBOOST_GET(_**) series macros.