solve mklml memory leak on windows #24015
Conversation
test=develop
| IF(WIN32) | ||
| SET(MKLML_VER "mklml_win_${TIME_VERSION}" CACHE STRING "" FORCE) |
There was a problem hiding this comment.
报错在这个地方 http://10.87.145.41:8111/viewLog.html?buildId=332739&buildTypeId=PaddleWindows_PrWindowsCi&tab=buildLog&branch_PaddleWindows=pull%2F24015&_focus=993
新的mklml比原来版本少了个msvcr120.dll，导致在这个地方
https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/fluid/pybind/CMakeLists.txt#L69-L74 拷贝出错了，需要看以下是要改mklml.cmake还是op_function_cmd这里
There was a problem hiding this comment.
新的mklml比原来版本少了个msvcr120.dll
@yinghu5 能帮忙看下这个msvcr120.dll是不是不需要了？
|
Hi Tao, |
| IF(WIN32) | ||
| SET(MKLML_VER "mklml_win_${TIME_VERSION}" CACHE STRING "" FORCE) | ||
| SET(MKLML_VER "mklml_win_2019.0.5.20190502" CACHE STRING "" FORCE) | ||
| SET(MKLML_URL "https://paddlepaddledeps.bj.bcebos.com/${MKLML_VER}.zip" CACHE STRING "" FORCE) | ||
| SET(MKLML_LIB ${MKLML_LIB_DIR}/mklml.lib) | ||
| SET(MKLML_IOMP_LIB ${MKLML_LIB_DIR}/libiomp5md.lib) |
There was a problem hiding this comment.
可以不需要，编译没问题。把依赖MKLML_SHARED_LIB_DEPS的地方去掉，有4个地方。另外demo_ci/CMakeLists.txt中有一个msvcr120.dll也需要去掉，共5个位置。
solve #23557 (comment)