-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TensorExpression #239
Add TensorExpression #239
Conversation
I LOVE this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
添加文档
@@ -117,6 +125,9 @@ endif(NOT WITH_TIMER) | |||
if(WITH_AVX) | |||
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${AVX_FLAGS}") | |||
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${AVX_FLAGS}") | |||
if(AVX_FOUND) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to WITH_GPU
Just FYI, https://github.com/ddemidov/vexcl Thanks, On Sun, Oct 30, 2016 at 8:51 PM, gangliao [email protected] wrote:
|
抱歉,之前看的时候没注意到有文档。 |
@hedaoyuan @reyoung 这个PR先不要merge吧,为了确保下一个milestone的release能比较stable,这个PR升级比较多,可以考虑放到下下个milestone,你们觉得呢? |
@hedaoyuan says |
Merge最新的develop代码,并且对tests中的一些conflicts进行修改。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TensorGpuApply<T>(*this, expr); | ||
} else { | ||
TensorCpuApply<T>(*this, expr); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
虽然不是特别严重的事情,不过 operator =
似乎应该返回自身的引用。这样才能写a=b=c
。不过我们也可以说,不能这么写code。
A new TensorExpression implementation. And there is a documentation , to assist in code review. This document is not complete, at present, do not consider merger into the master.