Add lock to record_event. #11346
Merged
Add lock to record_event. #11346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
reviewed
Jun 11, 2018
| @@ -100,6 +101,7 @@ class CUDADeviceContext : public DeviceContext { | |||
|
|
|||
| template <typename Callback> | |||
| void RecordEvent(cudaEvent_t ev, Callback callback) { | |||
| std::lock_guard<std::mutex> guard(mtx_); | |||
| callback(); | |||
There was a problem hiding this comment.
How about replacing std::mutex with std::recursive_mutex? Because, if the callback() contains another RecordEvent() calling, it will be hang again.
There was a problem hiding this comment.
This situation should not happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that transformer will still be hang without this lock.