-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/anakin ci #11330
feature/anakin ci #11330
Conversation
Superjomn
commented
Jun 10, 2018
•
edited
Loading
edited
@@ -61,6 +61,7 @@ option(EIGEN_USE_THREADS "Compile with multi-threaded Eigen" OFF) | |||
option(WITH_ARM_FP16 "Use half precision support on armv8.2-a cpu" OFF) | |||
option(WITH_FAST_BUNDLE_TEST "Bundle tests that can be run in a single process together to reduce launch overhead" OFF) | |||
option(WITH_CONTRIB "Compile the third-party contributation" OFF) | |||
option(WITH_ANAKIN "Compile with Anakin library" OFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci里要设成ON,测一下么?可以修改paddle_build.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already set in paddle_build.sh
CMakeLists.txt
Outdated
endif(WITH_GPU) | ||
|
||
if (NOT WITH_GPU) | ||
set(WITH_ANAKIN OFF CACHE STRING "Anakin is valid only when GPU is set." FORCE) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
184-192
if(WITH_GPU)
include(cuda)
include(tensorrt)
include(external/anakin)
else()
set(WITH_ANAKIN OFF CACHE STRING "Anakin is valid only when GPU is set." FORCE)
endif()
@@ -0,0 +1,41 @@ | |||
if (NOT WITH_ANAKIN) | |||
return() | |||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-3可以去掉。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下面会 wget anakin 的库,如果没有打开可以忽略所有下面的逻辑。
fetch_include_recursively(${root_dir}/${sub}) | ||
endif() | ||
endforeach() | ||
endfunction() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以用ExternalProject_Add
来写,会更加清晰和统一。不用自己写function了。参考:mklml.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有时间的话在另外一个 pr 里加吧。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM