-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplize API Reference Documentation #11308
Conversation
"with the specified value"); | ||
AddAttr<std::vector<int>>("shape", "(vector<int>) The shape of the output"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is stupid to write type again. The type has been registered by template arguments.
第一个API的indentation,从“It also sets..."开始错位。 |
@skylarch Done. |
|
@JiayiFeng Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I think we'd better let @shanyi15 take a look at this before merging it.
comment += escape_inline_math(line) | ||
comment += " " | ||
elif len(comment) != 0: | ||
comment += "\n \n " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why need to add spaces at then end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It correctly indent the comment to 4 spaces. It needed for google style comments.
It is tricky now. It should use regex to detect indent length.
elif len(comment) != 0: | ||
comment += "\n \n " | ||
|
||
args = {"comment": trim_ending_dot(comment)} | ||
for each_input in op_proto.inputs: | ||
input_name = _convert_(each_input.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_convert_
seems will output wired string when input is something like ROIs
, outputs ro_is
. Just put out this problem.
Or maybe we can just check that name is valid?
@skylarch , please recheck the format |
Polish
fill_constant_batch_size_like
,load
,max_sequence_len
,resize_bilinear2d
:load
fromtensor
toio