enable infer api with multi-threads #11162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyx0718
reviewed
Jun 5, 2018
| @@ -54,17 +54,23 @@ std::string num2str(T a) { | |||
| } | |||
| } // namespace | |||
|
|
|||
| bool NativePaddlePredictor::Init() { | |||
| bool NativePaddlePredictor::Init(std::shared_ptr<framework::Scope> scope) { | |||
There was a problem hiding this comment.
Can this be unique_ptr? and std::moved around?
There was a problem hiding this comment.
Why is there no change in CreatePaddlePredictor?
There was a problem hiding this comment.
Can this be unique_ptr? and std::moved around?
I am afraid not, this scope should be parent scope and the sub scope should be depend on it
Why is there no change in CreatePaddlePredictor?
Because as default only need change Clone.
panyx0718
reviewed
Jun 5, 2018
| @@ -34,14 +34,15 @@ class NativePaddlePredictor : public PaddlePredictor { | |||
| explicit NativePaddlePredictor(const NativeConfig &config) | |||
| : config_(config) {} | |||
|
|
|||
| bool Init(); | |||
| // will only create sub scope if have global scope | |||
| bool Init(std::shared_ptr<framework::Scope> scope = nullptr); | |||
There was a problem hiding this comment.
Sure~ will update it.
panyx0718
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @Superjomn 's suggestion, the usage should be like this:
So, we should only focus on thread-safe and sharing parameters.