Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine benchmark/fluid #11158

Merged
merged 2 commits into from
Jun 5, 2018
Merged

refine benchmark/fluid #11158

merged 2 commits into from
Jun 5, 2018

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Jun 4, 2018

  • refine benchmark/.gitigone
  • fix typo of argument learning_rate
  • add argument --cpus for multi-thread cpus
  • use a common function print_train_time to reduce lines
  • mkdir -p logs to store all the logs
  • fix --models=resnet50 to --models=resnet, since the file name resnet.py.
  • fix the issue when running with --gpus > 1, duplicated with Fluid benchmark support recordio reader #11121 (comment)

@luotao1 luotao1 requested a review from typhoonzero June 4, 2018 13:00
typhoonzero
typhoonzero reviewed Jun 5, 2018
View reviewed changes
benchmark/fluid/fluid_benchmark.py Outdated
@@ -72,6 +69,11 @@ def parse_args():
type=int,
default=1,
help='If gpus > 1, will use ParallelExecutor to run, else use Executor.')
parser.add_argument(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not see changes to deal with --cpus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Remove it and will add in next PR when using ParallelDo to do multi-thread CPU training.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@luotao1 luotao1 merged commit f2c5574 into PaddlePaddle:develop Jun 5, 2018
@luotao1 luotao1 deleted the benchmark1 branch June 5, 2018 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luotao1 @typhoonzero