[Do not merge] Fix nondeterminism issue wrt sentiment analysis chapter #11133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #11057 we get non-deterministic outputs for a couple of examples.
I tried debugging the sentiment analysis model: https://github.com/sidgoyal78/Paddle/blob/a801e7bcb2f4f1e131f6a640ecd84a03d21588ff/test_sa_conv.py
by actually saving the weights after each iteration, and also printing inputs and outputs at individual CUDA kernels. I have some findings that I wanted to share:
In order to get consistent results I had to change the launching of both of these kernels to allow for only 1 thread.
So in summary the issue is with CUDA atomics. This was pointed out by Greg in a discussion recently, and there is another comment here: tensorflow/tensorflow#3103 (comment)
With these changes, we get consistent results but at the cost of performance.
Moreover, if we change the optimizer to Adam in the above example, then we don't get consistent results. So probably there is some problem with Adam optimizer as well.
Note: With launching just one thread, we don't get correct results, since only a part of the actual work is done. However, this PR is for highlighting the consistency problem (but I want to be clear that launching 1 thread does result in incorrect outputs, as can be seen in the failed unit tests).
@dzhwinter @chengduoZH : What do you guys think?