Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference API little fix #11069

Merged
merged 9 commits into from
May 31, 2018

Conversation

Superjomn
Copy link
Contributor

No description provided.

@Superjomn Superjomn changed the title WIP inference API little fix inference API little fix May 31, 2018

if(WITH_CONTRIB)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样写,有点多,能不能改成:

if(WITH_CONTRIB)
   set(fluid_modules ${fluid_modules} paddle_inference_api)
endif()

后面就可以保持不变了。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我改下

@Superjomn Superjomn requested a review from panyx0718 May 31, 2018 08:08
panyx0718
panyx0718 previously approved these changes May 31, 2018
* non-sequence scenerios.
* TODO(Superjomn) Prepare another API for NLP-related usages.
*/
* A simple Inference API for Paddle. Currently this API might just be used by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might -> can

*/
* A simple Inference API for Paddle. Currently this API might just be used by
* non-sequence scenerios.
* TODO(Superjomn) Prepare another API for NLP-related usages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" Prepare another API for" -> "Support"

@Superjomn Superjomn merged commit 97b7502 into PaddlePaddle:develop May 31, 2018
@Superjomn Superjomn deleted the feature/inference_api_fix branch May 31, 2018 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants