Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix training parameter issue #10037

Merged
merged 4 commits into from
Apr 19, 2018
Merged

fix training parameter issue #10037

merged 4 commits into from
Apr 19, 2018

Conversation

putcn
Copy link
Contributor

@putcn putcn commented Apr 18, 2018

fix #10036

@putcn putcn requested a review from helinwang April 18, 2018 22:03
helinwang
helinwang reviewed Apr 18, 2018
View reviewed changes
tools/aws_benchmarking/server/cluster_master.py Outdated
if ":" in seg:
parameters = seg.split(":")
parameter_map[parameters[0]] = parameters[1]
#seg = "--" + seg.replace(":", " ")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove commented code? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review, done

helinwang
helinwang approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@putcn putcn merged commit 6231035 into PaddlePaddle:develop Apr 19, 2018
@putcn putcn deleted the fix-command-escape branch April 24, 2018 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helinwang helinwang helinwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issue while passing customized training parameters to aws benchmark tool
2 participants
@putcn @helinwang