Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the main function inside the test file #975

Closed
hedaoyuan opened this issue Dec 21, 2016 · 2 comments
Closed

Remove the main function inside the test file #975

hedaoyuan opened this issue Dec 21, 2016 · 2 comments
Assignees
@hedaoyuan @tianbingsz

Comments

@hedaoyuan
Copy link
Contributor

Most of the main functions in the test file are the same.
Move function/TestMain.cpp to utils, and remove the main function in the test files.
@hedaoyuan hedaoyuan self-assigned this Dec 21, 2016
@reyoung
Copy link
Collaborator

reyoung commented Dec 21, 2016

It will lead the paddle modules(gserver, trainer, etc.) to depend on gtest library, which could be unnecessary.

Maybe extract to a module only used for unit tests is better.

@hedaoyuan
Copy link
Contributor Author

There is no dependency problem. Only the executable of the test case is linked to TestMain.cpp.

It will lead the paddle modules(gserver, trainer, etc.) to depend on gtest library

@tianbingsz tianbingsz self-assigned this Dec 21, 2016
@hedaoyuan hedaoyuan mentioned this issue Dec 23, 2016
Merged
wangxicoding pushed a commit to wangxicoding/Paddle that referenced this issue Dec 9, 2021
@LiuChiachi
update clue dataset, and remove useless argment for run_clue (PaddleP…
6e39f20 
…addle#975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hedaoyuan hedaoyuan

@tianbingsz tianbingsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reyoung @hedaoyuan @tianbingsz