【Hackathon 5th No.44】API转换 42-61 -part #324

co63oc · 2023-11-05T03:15:15Z

PR Docs

https://github.com/PaddlePaddle/community/blob/master/hackathon/hackathon_5th/%E3%80%90PaddlePaddle%20Hackathon%205th%E3%80%91%E5%BC%80%E6%BA%90%E8%B4%A1%E7%8C%AE%E4%B8%AA%E4%BA%BA%E6%8C%91%E6%88%98%E8%B5%9B%E6%A1%86%E6%9E%B6%E5%BC%80%E5%8F%91%E4%BB%BB%E5%8A%A1%E5%90%88%E9%9B%86.md#no46%E4%B8%BApaddle%E4%BB%A3%E7%A0%81%E8%BD%AC%E6%8D%A2%E5%B7%A5%E5%85%B7%E6%96%B0%E5%A2%9Eapi%E8%BD%AC%E6%8D%A2%E8%A7%84%E5%88%99
API转换名单中第5组（编号为84 ~ 102）

文档 PR PaddlePaddle/docs#6288

PR APIs

42	torch.linalg.eigh	paddle.linalg.eigh	返回第二个值参数符号不同，不确定是否是功能缺失
43	torch.linalg.eigvalsh	paddle.linalg.eigvalsh	已有文档验证无误
44	torch.linalg.pinv	paddle.linalg.pinv	修改文档参数
45	torch.linalg.svd	paddle.linalg.svd	返回值只有S相同，U，V部分值符号不同，不确定是否分类功能缺失
46	torch.linalg.solve	paddle.linalg.solve	已有文档验证无误
47	torch.linalg.eig	paddle.linalg.eig	修改文档参数
48	torch.Tensor.float_power		增加文档，组合替代实现
49	torch.Tensor.float_power_		增加文档，组合替代实现
50	torch.Tensor.lstsq	paddle.Tensor.lstsq	功能缺失，文档已说明返回值不同，原修改PR  https://github.com/PaddlePaddle/PaConvert/pull/219
51	torch.pca_lowrank	paddle.linalg.pca_lowrank	已有文档验证无误
52	torch.symeig	paddle.linalg.eigh	python1.9以上版本不支持，修改文档内容，如果替换为eigh，返回值第二个参数符号不同
53	torch.Tensor.symeig	paddle.linalg.eigh	python1.9以上版本不支持，修改文档内容，如果替换为eigh，返回值第二个参数符号不同
54	torch.linalg.inv_ex	paddle.linalg.inv	功能缺失，pytorch 返回info字段，paddle不支持
55	torch.linalg.matrix_norm	paddle.linalg.norm	增加文档
56	torch.linalg.vector_norm	paddle.linalg.norm	增加文档
57	torch.linalg.cholesky_ex	paddle.linalg.cholesky	功能缺失，pytorch 返回info字段，paddle不支持
58	torch.Tensor.cholesky_solve	paddle.Tensor.cholesky_solve	修改文档参数
59	torch.Tensor.triangular_solve	paddle.Tensor.triangular_solve	修改文档分类
60	torch.autograd.enable_grad	paddle.enable_grad	增加文档
61	torch.autograd.set_grad_enabled	paddle.set_grad_enabled	增加文档

torch.linalg.eigh 返回值符号不同

torch.linalg.svd 返回值符号不同

paconvert/api_mapping.json

tests/test_Tensor_float_power_.py

tests/test_Tensor_symeig.py

tests/test_linalg_eigh.py

tests/test_linalg_eigvalsh.py

tests/test_linalg_matrix_norm.py

paconvert/api_mapping.json

paddle-bot · 2023-11-10T10:10:58Z

Thanks for your contribution!

zhwesky2010

注意单测不能屏蔽

zhwesky2010 · 2023-11-14T12:50:58Z

tests/test_Tensor_symeig.py

+    obj.run(pytorch_code, ["result"])
+
+
+def _test_case_4():


这些单测为何屏蔽了？

symeig 会转为 eigh，eigh 返回值符号不同

pytorch 1.9 以上不支持

zhwesky2010 · 2023-11-14T12:55:40Z

tests/test_linalg_eigh.py

+obj = APIBase("torch.linalg.eigh")
+
+
+def _test_case_1():


这些单测为何都屏蔽了？是Matcher写的不对吗

torch.linalg.eigh 返回值符号不同

建议测绝对值

已修改，测试发现是 paddle cpu和gpu版本计算结果符号不同，cpu版本没有问题

zhwesky2010 · 2023-11-14T12:55:48Z

tests/test_linalg_svd.py

+obj = APIBase("torch.linalg.svd")
+
+
+def _test_case_1():


这些单测为何都屏蔽了？是Matcher写的不对吗

torch.linalg.svd 返回值符号不同

建议可以索引取出相同的值，对于符号不同的，测paddle.abs()的结果。

测结果可以稍灵活点，但肯定不能不测

已修改，测试发现是 paddle cpu和gpu版本计算结果符号不同，cpu版本没有问题

zhwesky2010 · 2023-11-14T12:56:02Z

tests/test_symeig.py

+obj = APIBase("torch.symeig", is_aux_api=True)
+
+
+def _test_case_1():


这些单测为何都屏蔽了？

symeig 会转为 eigh，eigh 返回值符号不同

pytorch 1.9 以上不支持

zhwesky2010 · 2023-11-15T11:08:19Z

@co63oc 辛苦再修改一下

co63oc · 2023-11-16T00:20:24Z

已修改

co63oc · 2023-11-16T03:52:10Z

@zhwesky2010 No.47

paddleslim中搜索对应API都是没有，不知道是什么问题

比如搜索 RandomUnstructured https://github.com/search?q=repo%3APaddlePaddle%2FPaddleSlim%20RandomUnstructured&type=code

zhwesky2010 · 2023-11-16T06:20:04Z

@zhwesky2010 No.47 paddleslim中搜索对应API都是没有，不知道是什么问题

比如搜索 RandomUnstructured https://github.com/search?q=repo%3APaddlePaddle%2FPaddleSlim%20RandomUnstructured&type=code

只是推测的可能位置，不做具体实现用。
具体实现时，还需要自行调研是否有 相应的功能位置 或者 组合替代方式，如果实在无法实现，则取消相应题目。

zhwesky2010

有一些小问题，后面改下吧，先approve了

paconvert/api_mapping.json

zhwesky2010 · 2023-11-16T06:58:36Z

tests/test_linalg_pinv.py

+        import torch
+        x = torch.tensor([[1, 2], [2, 1]]).to(dtype=torch.float32)
+        out = torch.tensor([])
+        result = torch.linalg.pinv(x, atol=None, rtol=1e-5, hermitian=False, out=out)


可以测一个全部非关键字的

tests/test_pca_lowrank.py

co63oc · 2023-11-16T07:32:49Z

修改PR #329

co63oc added 3 commits November 5, 2023 11:00

Add tests

fbd7a89

Fix

b779b5e

Fix

2707c4d

paddle-bot bot added the contributor External developers label Nov 5, 2023

luotao1 mentioned this pull request Nov 6, 2023

【PaddlePaddle Hackathon 5th】开源贡献个人挑战赛 PaddlePaddle/Paddle#57262

Closed

luotao1 assigned luotao1 and zhwesky2010 Nov 7, 2023

zhwesky2010 reviewed Nov 9, 2023

View reviewed changes

Fix

a7aaa76

zhwesky2010 reviewed Nov 14, 2023

View reviewed changes

Fix

64c6bcd

zhwesky2010 approved these changes Nov 16, 2023

View reviewed changes

zhwesky2010 merged commit f55e8d7 into PaddlePaddle:master Nov 16, 2023

luotao1 changed the title ~~【Hackathon 5th No.44】API转换 42-61~~ 【Hackathon 5th No.44】API转换 42-61 -part Nov 16, 2023

co63oc mentioned this pull request Nov 16, 2023

【Hackathon 5th No.44】API转换 42-61 #329

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 5th No.44】API转换 42-61 -part #324

【Hackathon 5th No.44】API转换 42-61 -part #324

co63oc commented Nov 5, 2023

paddle-bot bot commented Nov 10, 2023

zhwesky2010 left a comment

zhwesky2010 Nov 14, 2023

co63oc Nov 15, 2023 •

edited

Loading

zhwesky2010 Nov 14, 2023

co63oc Nov 15, 2023

zhwesky2010 Nov 15, 2023

co63oc Nov 16, 2023 •

edited

Loading

zhwesky2010 Nov 14, 2023

co63oc Nov 15, 2023

zhwesky2010 Nov 15, 2023

co63oc Nov 16, 2023 •

edited

Loading

zhwesky2010 Nov 14, 2023

co63oc Nov 15, 2023 •

edited

Loading

zhwesky2010 commented Nov 15, 2023

co63oc commented Nov 16, 2023

co63oc commented Nov 16, 2023

zhwesky2010 commented Nov 16, 2023

zhwesky2010 left a comment

zhwesky2010 Nov 16, 2023

co63oc commented Nov 16, 2023

		obj = APIBase("torch.symeig", is_aux_api=True)


		def _test_case_1():

【Hackathon 5th No.44】API转换 42-61 -part #324

【Hackathon 5th No.44】API转换 42-61 -part #324

Conversation

co63oc commented Nov 5, 2023

PR Docs

PR APIs

paddle-bot bot commented Nov 10, 2023

zhwesky2010 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

co63oc Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

co63oc Nov 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

co63oc Nov 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

co63oc Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

zhwesky2010 commented Nov 15, 2023

co63oc commented Nov 16, 2023

co63oc commented Nov 16, 2023

zhwesky2010 commented Nov 16, 2023

zhwesky2010 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

co63oc commented Nov 16, 2023

co63oc Nov 15, 2023 •

edited

Loading

co63oc Nov 16, 2023 •

edited

Loading

co63oc Nov 16, 2023 •

edited

Loading

co63oc Nov 15, 2023 •

edited

Loading