Added timeout #24
Merged
Added timeout #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @chickahoona 👋 , thank you for submitting this PR to introduce a default connection timeout, please allow us to discuss it internally what might be an appropriate default value for it and we will let you know. |
|
Hello @chickahoona 👋, please update the default timeout to be 60 seconds and we will include this in the next release. (we may decide to decrease this default in future) |
chickahoona
force-pushed
the
timeout-v2
branch
from
529fa44 to
b384517
Compare
chickahoona
force-pushed
the
timeout-v2
branch
from
b384517 to
7c6c34a
Compare
|
Hi @davidgrayston-paddle Done |
davidgrayston-paddle
approved these changes
Sep 4, 2024
|
@chickahoona thank you for contributing this fix, we will release this shortly |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the SDK has no timeout configured. If Paddle services don't respond the request on my side will hang forever depleeding my resources / processes.