Fix: Transaction Preview Price #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgrayston-paddle
force-pushed
the
fix/transaction-preview-price
branch
from
7f50dff to
0b39445
Compare
| @@ -16,7 +16,7 @@ | |||
| class TransactionItemPreviewWithPrice | |||
| { | |||
| private function __construct( | |||
| public Price $price, | |||
| public Price|TransactionPreviewPrice $price, | |||
There was a problem hiding this comment.
We could make this TransactionPreviewPrice only?
There was a problem hiding this comment.
Just TransactionPreviewPrice would make it breaking so lets stick with the union 👍
There was a problem hiding this comment.
The non catalog prices are shared between operations, so have put them in their own namespace Paddle\SDK\Resources\Transactions\Operations\Price
mikeymike
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
TransactionsClient::preview()TransactionPreviewresponse now allows null price ID for non-catalog prices:TransactionPreviewitems[]->pricecan now returnPrice(withid) orTransactionPreviewPrice(with nullableid)TransactionPreviewdetails->lineItems[]->priceIdis now nullableAdded
TransactionsClient::create()now supports operation items with optional properties:Resources\Transactions\Operations\Create\TransactionCreateItemResources\Transactions\Operations\Create\TransactionCreateItemWithPriceTransactionsClient::update()now supports operation items with optional properties:Resources\Transactions\Operations\Update\TransactionUpdateItemResources\Transactions\Operations\Update\TransactionUpdateItemWithPriceTransactionsClient::preview()now supports operation items with optional properties:Resources\Transactions\Operations\Preview\TransactionItemPreviewWithNonCatalogPriceResources\Transactions\Operations\Preview\TransactionItemPreviewWithPriceIdDeprecated
TransactionsClient::create()operation items have been deprecated:Entities\Transaction\TransactionCreateItemEntities\Transaction\TransactionCreateItemWithPriceTransactionsClient::update()operation items have been deprecated:Entities\Transaction\TransactionUpdateTransactionItemTransactionsClient::preview()operation items have been deprecated:Entities\Transaction\TransactionItemPreviewWithNonCatalogPriceEntities\Transaction\TransactionItemPreviewWithPriceIdRelates to #87 and #88