TransactionLineItem should contain Product instead of ProductWithIncludes

[Invincibear]

The disclaimer at the top of the file says the code is auto-generated, I'm not positive this is a bug but according to the API spec, it seems that this should be using Product instead of ProductWithIncludes. Also, had to submit as a PR because GitHub discussions doesn't seem to be enabled for this repo. I haven't looked into TransactionLineItemPreview yet, I suspect it'll need the save review.

[Invincibear]

Yeah after looking at the API reference it appears that TransactionLineItemPreview also needs to reference Product instead of ProductWithIncludes

[Invincibear]

Looks like this might actually be a larger issue. I'm working through the ProductsClient and it has similar issues, methods returning ProductWithIncludes when it should only be returning Product. I think only get & list methods should return Entities with WithIncludes. I think a lot of this library needs to have the methods checked against the API docs for Includes.

[mikeymike]

Hey @Invincibear thanks for bringing this up it's a very important point. We made a decision early on that the way entities with includes work within the API specification isn't strictly ideal for the PHP type system where we'd result in 2 implementations of effectively the same entity making it trickier for consumers to reason with and pass objects around their codebase. When we made this decision we chose to utilise the EntityWithIncludes objects instead with some cleanup code required in the code generation to prevent the duplication.

I've created a new PR #15 that should hopefully clean this up now, I'll close this PR and the related one in favour of this.

Thanks again for highlighting this 👍