Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor get parameters by path call to not have 10 params limit #29

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Refactor get parameters by path call to not have 10 params limit #29

merged 1 commit into from
Aug 14, 2020

Conversation

geototti21
Copy link
Member

  • Refactor get parameters by path call to not have 10 params limit
  • Refactor to use GetParametersByPathPagesthat does the calls recursivly for us

Closes #28

@geototti21 geototti21 self-assigned this Aug 14, 2020
This was referenced Aug 14, 2020
Closed
Merged
@geototti21 geototti21 merged commit 40470bb into master Aug 14, 2020
@geototti21 geototti21 deleted the issue-28 branch August 14, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apzuk3 apzuk3 apzuk3 approved these changes

@danielfosbery danielfosbery Awaiting requested review from danielfosbery

@marioarranzr marioarranzr Awaiting requested review from marioarranzr

@simon-chettle simon-chettle Awaiting requested review from simon-chettle

Assignees

@geototti21 geototti21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to fetch more than 10 params (that is the limit on aws sdk)
2 participants
@geototti21 @apzuk3