Merge pull request #4 from PaddleHQ/make-parameters-more-testable

Make Parameters unaware of aws

parameter.go

@@ -5,21 +5,20 @@ import (
 	"io"
 	"strings"
 
-	"github.com/aws/aws-sdk-go/service/ssm"
 	"github.com/mitchellh/mapstructure"
 )
 
 //Parameter holds a Systems Manager parameter from AWS Parameter Store
 type Parameter struct {
-	ssmParameter *ssm.Parameter
+	Value *string
 }
 
-//GetValue return the actual value of the parameter
+//GetValue return the actual Value of the parameter
 func (p *Parameter) GetValue() string {
-	if p.ssmParameter.Value == nil {
+	if p.Value == nil {
 		return ""
 	}
-	return *p.ssmParameter.Value
+	return *p.Value
 }
 
 //NewParameters creates a Parameters

parameter_store_client.go

@@ -42,7 +42,7 @@ func (c *ParameterStore) getParameters(input *ssm.GetParametersByPathInput) (*Pa
 		if v.Name == nil {
 			continue
 		}
-		parameters.parameters[*v.Name] = &Parameter{ssmParameter: v}
+		parameters.parameters[*v.Name] = &Parameter{Value: v.Value}
 	}
 	return parameters, nil
 }

parameter_store_client_test.go

@@ -47,8 +47,8 @@ func TestClient_GetParametersByPath(t *testing.T) {
 			expectedOutput: &Parameters{
 				basePath: "/my-service/dev/",
 				parameters: map[string]*Parameter{
-					"/my-service/dev/DB_PASSWORD": {ssmParameter: param1},
-					"/my-service/dev/DB_HOST":     {ssmParameter: param2},
+					"/my-service/dev/DB_PASSWORD": {Value: param1.Value},
+					"/my-service/dev/DB_HOST":     {Value: param2.Value},
 				},
 			},
 		},

parameter_test.go

@@ -115,7 +115,7 @@ func TestParameters_Decode(t *testing.T) {
 
 func getParametersMap() map[string]*Parameter {
 	return map[string]*Parameter{
-		"/my-service/dev/DB_PASSWORD": {ssmParameter: param1},
-		"/my-service/dev/DB_HOST":     {ssmParameter: param2},
+		"/my-service/dev/DB_PASSWORD": {Value: param1.Value},
+		"/my-service/dev/DB_HOST":     {Value: param2.Value},
 	}
 }