Exploratory: Alternative Node.js target implementation #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to port Weblink to other platforms, such as Node.js, because it effectively reduces the needed API surface area.
It certainly lacks in certain areas, e.g. the included test suite does not compile yet. However, the basic logic is present and a simple Hello World example does build and work.
By moving the server to a background thread, we can better handle blocking HTTP requests. Additionally, while the Node.js version of the tests still does not compile, it will use very similar semantics in the future.
This should allow actual persistent connections (keep-alive). Pipelining and multiplexing are still not supported.
|
Hey sorry going to go through and review all of your prs now. I greatly appreciate the effort you put into them @Frixuu , and I hope to get them all merged very swiftly, as I like the direction of the pull requests, and you have written very nice code. |
Frixuu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach requires app devs to depend on deasync, a small native Node module that allows some of the code to be blocking.
Additionally: