Download different log formats #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Aug 22, 2023
Comment on lines
+79
to
+89
| vehicle_id = 1 # You can set this to the appropriate vehicle ID | ||
| component_id = 1 # You can set this to the appropriate component ID | ||
| version = "1.14.0 beta" # Set the version accordingly | ||
| git_revision = "0099523710000000" # Set the Git revision accordingly | ||
|
|
||
| self.write(f"# Onboard parameters for Vehicle {vehicle_id}\n") | ||
| self.write("#\n") | ||
| self.write(f"# Stack: PX4 Pro\n") | ||
| self.write("# Vehicle: Multi-Rotor\n") | ||
| self.write(f"# Version: {version}\n") | ||
| self.write(f"# Git Revision: {git_revision}\n") |
There was a problem hiding this comment.
Can you get these from the log or remove altogether? I prefer having no info over something incorrect.
Comment on lines
+16
to
+25
| sys.path.append( | ||
| os.path.join(os.path.dirname(os.path.realpath(__file__)), "../plot_app") | ||
| ) | ||
| from helper import ( | ||
| get_log_filename, | ||
| validate_log_id, | ||
| flight_modes_table, | ||
| load_ulog_file, | ||
| get_default_parameters, | ||
| ) |
There was a problem hiding this comment.
Could you please avoid unrelated style changes (or minimally separate by commits. In this case there's CI to check the style)? It makes things hard to review.
| rgb[i] += 40 | ||
| if rgb[i] > 255: rgb[i] = 255 | ||
| param_value = ulog.initial_parameters[param_key] | ||
| param_type = "9" # Assuming the type is always "9" (FLOAT), you can modify it if needed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this PR as proposed by @afwilkin in Ascend Engineering, we could add the capability of downloading .params format of the parameters since now the params can only be downloaded in raw formats. The user can have all RAW, txt and params format.
Below is the screenshot of what this PR could add already:
Reviews are highly appreciated.