Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Pr liftdrag coefficients (#690)" #730

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Revert "Pr liftdrag coefficients (#690)" #730

merged 1 commit into from
Mar 16, 2021

Conversation

Jaeyoung-Lim
Copy link
Member

Problem Description
This PR reverts #690 since it is introducing a number of problems for fixedwing vehicles

The issues include

Additional Context

@Jaeyoung-Lim Jaeyoung-Lim requested a review from TSC21 March 16, 2021 11:24
@Jaeyoung-Lim Jaeyoung-Lim merged commit b195315 into master Mar 16, 2021
@Jaeyoung-Lim Jaeyoung-Lim deleted the pr-revert-liftdrag branch March 16, 2021 11:55
TSC21
TSC21 reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@TSC21 TSC21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjdewitte this needs to be revisited

C-Glick added a commit to Open-UAS/PX4-SITL_gazebo that referenced this pull request Mar 18, 2021
@C-Glick
Reverted PX4#690 on UAS model see PX4#730 and b195315
625c215
@Jaeyoung-Lim Jaeyoung-Lim mentioned this pull request Mar 19, 2021
Closed
Jaeyoung-Lim added a commit that referenced this pull request Mar 19, 2021
@Jaeyoung-Lim
Revert "Revert "Pr liftdrag coefficients (#690)" (#730)"
2fa73c5 
This reverts commit b195315.
RyosukeMatsushima pushed a commit to RyosukeMatsushima/PX4-SITL_gazebo that referenced this pull request Jun 21, 2022
@Jaeyoung-Lim @pjdewitte
Revert "Pr liftdrag coefficients (PX4#690)" (PX4#730)
7a4578f 
This reverts commit 38224fb.

Co-authored-by: Pieter-Jan Dewitte <[email protected]>
junwoo091400 added a commit to junwoo091400/PX4-SITL_gazebo that referenced this pull request Sep 26, 2022
@junwoo091400
Rename cl_delta to control_joint_rad_to_cl
eb69f41 
- This fixes the transition crash error, which seems to be related to
PX4#710 as well.
- While standard_vtol.sdf.jinja was updated to the new naming
convention, the standard_vtol_drop was not updated, this commit fixes
that.
- Also, PX4#730 is also relevant
for this issue.
@junwoo091400 junwoo091400 mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TSC21 TSC21 TSC21 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tecpod fixedwing vehicle unable to takeoff
3 participants
@Jaeyoung-Lim @TSC21 @pjdewitte