This repository has been archived by the owner on May 1, 2024. It is now read-only.
EV_yaw: reset ev_to_ekf to identity when yaw is reset to EV #1016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the old rotation matrix is used and not updated anymore because the EKF is fusing EV yaw data.
Note that this issue only occurs when
MASK_ROTATE_EV
andMASK_EV_YAW
are set at the same time (because otherwise, ifMASK_ROTATE_EV
isn't set, the wrong rotation matrix is never used).Explanation of the race condition:
MASK_ROTATE_EV
is set, the data is rotated using the rotation matrix computed in 1 (which is now wrong)Added a unit test that triggers the race condition above (fails without the fix).