autopilot_tester: fix speed factor to fix CI #22811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfuhrer
changed the title
|
Converted to draft because it's still failing in CI, though not locally. I'm on it. |
Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
…o account And increase the (simulation time) timeouts. Signed-off-by: Silvan Fuhrer <[email protected]>
sfuhrer
force-pushed
the
pr-autopilot-tester-fix-speed-factor-main
branch
from
bf40626 to
a47c781
Compare
|
This indeed seems to make the wind SITL test more robust. The other 4 CI failures that happen in this specific PR atm are not related to it. |
|
@julianoes any chance you could review? |
bkueng
previously approved these changes
Apr 23, 2024
MaEtUgR
previously approved these changes
Apr 23, 2024
sfuhrer
force-pushed
the
pr-autopilot-tester-fix-speed-factor-main
branch
from
a47c781 to
2fa8ff9
Compare
julianoes
reviewed
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
MAVSDK VTOL standard wind ramp test failing
Solution
Changelog Entry
For release notes:
There's also other timeouts in autopilot_tester that are meant to be in simulation time but are currently in real time, though the mission end timeout seemed to have been the only one causing issues (prob because the timeouts are set more constraining there then on others that are shorter).