Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmu-v6c: fix Telem1, Telem2 without flow control #21540

Merged
merged 1 commit into from
May 4, 2023
Merged

fmu-v6c: fix Telem1, Telem2 without flow control #21540

merged 1 commit into from
May 4, 2023

Conversation

julianoes
Copy link
Contributor

@julianoes julianoes commented May 2, 2023 •
edited
Loading

When flow control is used together with DMA, we need to add a pulldown to RTS and CTS. Without it, it assumes flow control and gets stuck when RTS and CTS are is not connected.

Same as #20974 but for 6C.

@julianoes julianoes requested a review from davids5 May 2, 2023 19:58
davids5
davids5 requested changes May 3, 2023
View reviewed changes
Copy link
Member

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why RTS? CTS is the input that flow controls our TX.

Did you test and find the RTS change was needed?

Also when #21495 comes in we can fix all the pin settings so #undef GPIO_UART5_CTS will not be needed.

@julianoes
Copy link
Contributor Author

Ok, I just copied the other PR (#20974), I'll remove the RTS.

@julianoes
fmu-v6c: fix Telem1, Telem2 without flow control
3020203 
When flow control is used together with DMA, we need to add a pulldown
to CTS. Without it, it assumes flow control and gets stuck when
CTS is not connected.

Signed-off-by: Julian Oes <[email protected]>
@julianoes julianoes force-pushed the pr-6c-flow-control-and-dma branch from 8f96c60 to 3020203 Compare May 3, 2023 20:33
@davids5 davids5 self-requested a review May 4, 2023 06:21
davids5
davids5 approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julianoes LGTM - Did you want to add the same change in the other PR?

@julianoes
Copy link
Contributor Author

julianoes commented May 4, 2023 •
edited
Loading

Thanks, I'll do a follow up PR for that.
#21550

@julianoes julianoes merged commit 3cc940c into main May 4, 2023
@julianoes julianoes deleted the pr-6c-flow-control-and-dma branch May 4, 2023 20:02
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/pixhawk-6c-telem2-communication-issue-with-mavros/32255/2

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/problems-connecting-a-pixhawk-6c-to-a-raspberry-pi/32318/4

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/help-with-uxrce-dds-to-serial-connection-pixhawk-6c/32528/8

@julianoes julianoes mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davids5 davids5 davids5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianoes @DronecodeBot @davids5