Px4 firmware nuttx 10.3.0+ stm32 backports #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id use of the priv field for EP This field is for use in the class driver, not in the controller logic
…able compatibility
…initions to header files This value is useful for users when initializing a USB composite device in a board-specific logic
… after enabling IRQMONITOR
This is not documented by ST at all but otherwise ULPI is dead.
…ion if IN request is not possible to transfer Otherwise, a request will never be transferred and there is no information to the user that something is wrong. For example, when using default values for TXFIFO in HS mode, USBMSC will never work because the maximum request len is 512B which is lower than the default TXFIFO size for IN EP.
It seems that over-drive is not required for ULPI but it can be a workaround solution for boards with poor signal integration. Higher core voltage means faster clock signal edges, which may be sufficient to synchronize the high-speed clock and data on poorly designed boards. Over-drive can be forced to a given state by adding define to the board.h configuration file: #define STM32_VOS_OVERDRIVE 1 - force over-drive enabled, #define STM32_VOS_OVERDRIVE 0 - force over-drive disabled, #undef STM32_VOS_OVERDRIVE - autoselect over-drive by the default RCC logic
…stm32h7x7xx Over-drive can be forced to a given state by adding define to the board.h configuration file: #define STM32_VOS_OVERDRIVE 1 - force over-drive enabled, #define STM32_VOS_OVERDRIVE 0 - force over-drive disabled, #undef STM32_VOS_OVERDRIVE - autoselect over-drive by the default RCC logic
tools/stm32_pinmap_tool: Generate legacy file stm32_pinmap_tool:Handel #undef
Pinmaps should not have contained GPIO_SPEED_xxx settings. This is board dependent. This change adds CONFIG_STM32H7_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps without speeds. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, STM32H7_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set STM32H7_USE_LEGACY_PINMAP=n and fully define the pins in board.h
Pinmaps should not have contained GPIO_SPEED_xxx settings. This is board dependent. This change adds CONFIG_STM32F7_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps without speeds. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, STM32F7_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set STM32F7_USE_LEGACY_PINMAP=n and fully define the pins in board.h
…pinmap Pinmaps should not have contained GPIO_SPEED_xxx settings. This is board dependent. This change adds CONFIG_STM32_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps without speeds. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, STM32_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set STM32_USE_LEGACY_PINMAP=n and fully define the pins in board.h
…acy pinmap Pinmaps should not have contained GPIO_SPEED_xxx settings. This is board dependent. This change adds CONFIG_STM32_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps without speeds. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, STM32_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set STM32_USE_LEGACY_PINMAP=n and fully define the pins in board.h
…dd legacy pinmap Pinmaps should not have contained GPIO_SPEED_xxx settings. This is board dependent. This change adds CONFIG_STM32_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps without speeds. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, STM32_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set STM32_USE_LEGACY_PINMAP=n and fully define the pins in board.h
…and add legacy pinmap Pinmaps should not have contained GPIO_SPEED_xxx settings. This is board dependent. This change adds CONFIG_STM32_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps without speeds. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, STM32_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set STM32_USE_LEGACY_PINMAP=n and fully define the pins in board.h
…acy pinmap Pinmaps should not have contained GPIO_SPEED_xxx settings. This is board dependent. This change adds CONFIG_STM32_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps without speeds. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, STM32_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set STM32_USE_LEGACY_PINMAP=n and fully define the pins in board.h
replace all GPIO_MODE_xxMHz with GPIO_MODE_2MHz provide GPIO_ADJUST_MODE
and add legacy pinmap
For the stm32F1 pinmaps should not have contained GPIO_MODE_50MHz settings
on all pins. Speed is board dependent.
This change adds CONFIG_STM32_USE_LEGACY_PINMAP to allow for
lazy migration to using pinmaps that can have the GPIO_MODE_xxMHz set.
The work required to do this can be aided by running tools/stm32_pinmap_tool.py.
The tools will take a board.h, and use all the defconfigs with the legacy
pinmap and output the required changes that one needs to make to a board.h
file.
Eventually, CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated and the legacy
pinmaps removed from NuttX.
Any new boards added should set CONFIG_STM32_USE_LEGACY_PINMAP=n and
fully define the pins in board.hf1
…EED_xxx and add legacy pinmap Pinmaps should not have contained GPIO_SPEED_xxx settings. This is board dependent. This change adds CONFIG_STM32L4_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps without speeds. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, CONFIG_STM32L4_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set CONFIG_STM32L4_USE_LEGACY_PINMAP=n and fully define the pins in board.h
…ve GPIO_SPEED_xxx and add legacy pinmap Pinmaps should not have contained GPIO_SPEED_xxx settings. This is board dependent. This change adds CONFIG_STM32F0G0L0_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps without speeds. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, CONFIG_STM32F0G0L0_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set CONFIG_STM32F0G0L0_USE_LEGACY_PINMAP=n and fully define the pins in board.h
Pinmaps should not have contained GPIO_SPEED_xxx settings and all pins should have had suffixes to allow any pins attributes to be set. This is board dependent. This change adds CONFIG_STM32WB_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps with suffixes. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, CONFIG_STM32WB_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set CONFIG_STM32WB_USE_LEGACY_PINMAP=n and fully define the pins in board.h
Pinmaps should not have contained GPIO_SPEED_xxx settings and all pins should have had suffixes to allow any pins attributes to be set. This is board dependent. This change adds CONFIG_STM32L5_USE_LEGACY_PINMAP to allow for lazy migration to using pinmaps with suffixes. The work required to do this can be aided by running tools/stm32_pinmap_tool.py. The tools will take a board.h file and a legacy pinmap and outut the required changes that one needs to make to a board.h file. Eventually, CONFIG_STM32L5_USE_LEGACY_PINMAP will be deprecated and the legacy pinmaps removed from NuttX. Any new boards added should set CONFIG_STM32L5_USE_LEGACY_PINMAP=n and fully define the pins in board.h
…USE_LEGACY_PINMAP
davids5
changed the title
bkueng
approved these changes
May 11, 2023
PX4BuildBot
pushed a commit
that referenced
this pull request
Aug 26, 2024
"/mnt/yang/qixinwei_vela_warnings_04_23/nuttx/include/sys/types.h", line 319: warning #228-D: trailing comma is nonstandard OK = 0, ^ "/mnt/yang/qixinwei_vela_warnings_04_23/nuttx/include/sys/types.h", line 319: warning #228-D: trailing comma is nonstandard OK = 0, ^ "/mnt/yang/qixinwei_vela_warnings_04_23/nuttx/include/sys/types.h", line 319: warning #228-D: trailing comma is nonstandard OK = 0, ^ "/mnt/yang/qixinwei_vela_warnings_04_23/nuttx/include/sys/types.h", line 319: warning #228-D: trailing comma is nonstandard OK = 0, ^ "/mnt/yang/qixinwei_vela_warnings_04_23/nuttx/include/sys/types.h", line 319: warning #228-D: trailing comma is nonstandard OK = 0, ^ "/mnt/yang/qixinwei_vela_warnings_04_23/nuttx/include/sys/types.h", line 319: warning #228-D: trailing comma is nonstandard OK = 0, ^ "/mnt/yang/qixinwei_vela_warnings_04_23/nuttx/include/sys/types.h", line 319: warning #228-D: trailing comma is nonstandard OK = 0, Signed-off-by: yanghuatao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This brings in the Pinmap changes for all the stm32 to allow the board to set all attributes (SPEED,PU/PD etc).
The default is to use the legacy maps to allow lazy migration of each BSP to define it's pins fully. See tools/stm32_pinmap_tool.py
This also brings in USB changes for otg/ulpi
Impact
Testing