Bug 38089: (follow-up) More fixes for errors in original submission

The original submission missed a number of slip types that are print on demand without queueing. These all need an "id" passing in to the template and in some cases we were also missing passing in the new style parameter too (preservation) Signed-off-by: Katrin Fischer <[email protected]>
PTFS-Europe · Oct 11, 2024 · 3ab343b · 3ab343b
1 parent 03e17cd
commit 3ab343b
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 0 deletions.
diff --git a/circ/article-request-slip.pl b/circ/article-request-slip.pl
@@ -81,6 +81,7 @@
     caller => 'article-request',
     plain  => 0,
     style  => $style,
+    id     => 'ar_slip',
 );
 
 output_html_with_http_headers $cgi, $cookie, $template->output;
diff --git a/circ/hold-transfer-slip.pl b/circ/hold-transfer-slip.pl
@@ -54,6 +54,7 @@
 $template->param( caller => 'hold-transfer' );
 $template->param( plain  => !$is_html );
 $template->param( style  => $style );
+$template->param( id     => 'reserve_slip' );
 
 output_html_with_http_headers $input, $cookie, $template->output;
 
diff --git a/circ/transfer-slip.pl b/circ/transfer-slip.pl
@@ -60,6 +60,7 @@
     caller => 'cud-transfer',
     stylesheet => C4::Context->preference("SlipCSS"),
     style      => $style,
+    id         => 'transfer_slip',
 );
 
 output_html_with_http_headers $input, $cookie, $template->output;
diff --git a/members/print_overdues.pl b/members/print_overdues.pl
@@ -68,6 +68,7 @@
     plain          => !$letter->{is_html},
     borrowernumber => $borrowernumber,
     style          => $letter->{style},
+    id             => 'overdues_slip',
 );
 
 output_html_with_http_headers $input, $cookie, $template->output;
diff --git a/preservation/print_slip.pl b/preservation/print_slip.pl
@@ -40,6 +40,7 @@
 my $branch         = C4::Context->userenv->{'branch'};
 
 my @slips;
+my $count = 0;
 for my $train_item_id (@train_item_ids) {
     my $train_item = Koha::Preservation::Train::Items->find($train_item_id);
     my $letter     = C4::Letters::GetPreparedLetter(
@@ -55,6 +56,8 @@
     push @slips, {
         content => $letter->{content},
         is_html => $letter->{is_html},
+        style   => $letter->{style},
+        id      => ++$count,
     };
 }
 

diff --git a/recalls/recall_pickup_slip.pl b/recalls/recall_pickup_slip.pl
@@ -70,6 +70,7 @@
     plain  => !$is_html,
     caller => 'recall',
     style  => $style,
+    id     => 'recall_request_det',
 );
 
 output_html_with_http_headers $input, $cookie, $template->output;