feat: ILS usage graphs #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new UsageGraphs.php file in the services/ILS folder, and creates the ILS_UsageGraphs class within it.
Adds a launch method to the ILSUsageGraph class
Determines which title is to be assigned to and displayed above the graph based on which link was clicked, and therefor which stat valued was passed as a query parameter.
Based on the stat value, determines whether the request will need to target the ils_records_usage_table or the user_ils_usage table
Creates a new UserILSUsage instance which will be used to generate and execute the qeuries allowing to fetch from the database the data to be displayed in the graph. Also starts building the query (adding group by month and year)
Based on the value of stat, adds the appropriate string to the query in order to finish building the select statement which will allow for the relevant data to be fetched from the database.
Fetches the data, and then assigns the result to the relevant property of dataSeries, so that it can then be displayed to the user, both as a graph and as a raw data table.
Creates a new ILSRecordUsage instance which will be used to generate and execute the qeuries allowing to fetch from the database the data to be displayed in the graph. Also starts building the query (adding group by month and year)
Based on the value of stat, adds the appropriate string to the query in order to finish building the select statement which will allow for the relevant data to be fetched from the database.
Fetches the data, and then assigns the result to the relevant property of dataSeries, so that it can then be displayed to the user, both as a graph and as a raw data table.
Adds a getbreadcrumbs method to the ILS_UsageGraphs class, mirroring the Admin_UsageGraph class.
Once the user has clicked a link, and navigated to the matching user graph page, this allows the ILS Integration section in the search option to remain open.
Check that the user has permission to view dashboards and system reports. No specific ILS report permission is checked as of now. Mirrors the permission checks for the ILS Integration Dashboard.
|
Code looks really good and appears to be working as expected. One small thing, the graph icons in the Usage Dashboard are all evenly spaced after the header, however in the ILD dashboard, some of the headers have spaces between them and the icons and some don't. |
This was referenced Jul 29, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An Aspen admin can now view a usage graph and a raw data table for each of the variables included in the ILS Integration dashboard. This feature used to be limited to the System Reports dashboard, and it is now being extended.
Note: the implementation is based on the the System Reports existing usage graphs, and intends to mirror it where possible
Features:
Test plan: