fix: prevent milestone progress overflow

PTFS-Europe · Nov 11, 2024 · 83cb211 · 83cb211
1 parent 69f3ad2
commit 83cb211
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/code/web/sys/Community/CampaignMilestone.php b/code/web/sys/Community/CampaignMilestone.php
@@ -200,8 +200,13 @@ public function addCampaignMilestoneProgressEntry( $object, $userId)
         $campaignMilestoneUsersProgress->ce_campaign_id = $this->campaignId;
         $campaignMilestoneUsersProgress->userId = $userId;
 
-        # If there isn't one, create it.
-        if (!$campaignMilestoneUsersProgress->find(true)) {
+        # There is one, bail if goal has already been met
+        if ($campaignMilestoneUsersProgress->find(true)) {
+            if ($campaignMilestoneUsersProgress->progress >= $this->goal) {
+                return;
+            }
+        # There isn't one, create it.
+        } else {
             $campaignMilestoneUsersProgress->progress = 0;
             $campaignMilestoneUsersProgress->insert();
         }