fix: Prevent abbreviation from displaying if replace fails

Placeholder replacements failed if placeholders in text were altered during text
manipulation.

code/web/interface/themes/responsive/Citation/harvard.tpl

@@ -1,5 +1,5 @@
-{if !empty($citeDetails.authors)}{$citeDetails.authors|escape} {/if}
-{if !empty($citeDetails.year)}({$citeDetails.year|escape}). {/if}
-<span style="font-style:italic;">{$citeDetails.title|escape}</span>
-{if !empty($citeDetails.edition)} {$citeDetails.edition|escape} {/if}
-{if !empty($citeDetails.publisher)}{$citeDetails.publisher|escape}. {/if}
+{if !empty($harvardDetails.authors)}{$harvardDetails.authors|escape} {/if}
+{if !empty($harvardDetails.year)}({$harvardDetails.year|escape}). {/if}
+<span style="font-style:italic;">{$harvardDetails.title|escape}</span>
+{if !empty($harvardDetails.edition)} {$harvardDetails.edition|escape} {/if}
+{if !empty($harvardDetails.publisher)}{$harvardDetails.publisher|escape}. {/if}

code/web/sys/CitationBuilder.php

@@ -184,7 +184,7 @@ public function getHarvard() {
 			'year' => $this->getHarvardYear(),
 			'edition' => $this->getHarvardEdition(),
 		];
-		$interface->assign('citeDetails', $harvard);
+		$interface->assign('harvardDetails', $harvard);
 		return 'Citation/harvard.tpl';
 	}
 
@@ -390,13 +390,14 @@ private function capitalizeTitle($str) {
 	 * @return string
 	 */
 	private function convertToSentenceCase($text) {
+
 		$abbreviations = [];
 
 		//Regex pattern to match common exceptions e.g. "R&B" and "USA"
 		$pattern = '/\b[A-Z&]+\b/';
 		//Generate placeholders for abbreviations that match the pattern
 		$text = preg_replace_callback($pattern, function($matches) use (&$abbreviations) {
-			$placeholder = uniqid('abbr_', true);
+			$placeholder = '[[abbr_' . count($abbreviations) . ']]';
 			$abbreviations[$placeholder] = $matches[0];
 			//Replace abbreviation with placeholder
 			return $placeholder;
@@ -428,7 +429,6 @@ private function getAPATitle() {
 		/*if (!((substr($title, -1) == '?') || (substr($title, -1) == '!'))) {
 			$title .= '.';
 		}*/
-
 		return $title;
 	}