Merge pull request #70 from AlexanderBlanchardAC/24.07.00_summon_face…

…t_uncheck_fix fix: adjust code for facets to allow them to be unchecked
PTFS-Europe · Jun 11, 2024 · 2f2aa6f · 2f2aa6f
2 parents f8223de + 8f9492a
commit 2f2aa6f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/code/web/release_notes/24.07.00.MD b/code/web/release_notes/24.07.00.MD
@@ -11,6 +11,8 @@
 // katherine
 
 // alexander
+### Summon Updates
+- Adjustments to code in Summon getFacetSet function to correct a bug. Individual facet filters can now be unchecked and the filter unset by clicking the checkbox. (*AB*)
 
 // jacob
 

diff --git a/code/web/sys/SearchObject/SummonSearcher.php b/code/web/sys/SearchObject/SummonSearcher.php
@@ -486,15 +486,15 @@ public function getFacetSet() {
 				foreach ($facetField['counts'] as $value) {
 					$facetValue = $value['value'];
 					//Ensures selected facet stays checked when selected - interacts with .tpl
-					$isApplied = array_key_exists($facetId, $this->filterList) && in_array($value, $this->filterList[$facetId]);
+					$isApplied = array_key_exists($facetId, $this->filterList) && in_array($facetValue, $this->filterList[$facetId]);
 					$facetSettings = [
 						'value' => $facetValue,
 						'display' =>$facetValue,
 						'count' =>$value['count'],
 						'isApplied' => $value['isApplied'],
 					];
 					if ($isApplied) {
-						$facetSettings['removalUrl'] = $this->renderLinkWithoutFilter($facetId . ':' . $value);
+						$facetSettings['removalUrl'] = $this->renderLinkWithoutFilter($facetId . ':' . $facetValue);
 					} else {
 						$facetSettings['url'] = $this->renderSearchUrl() . '&filter[]=' . $facetId . ':' . urlencode($facetValue);
 					}