Merge pull request #64 from ammopt/plane_141

Fix display of 'small' covers in collection spotlights
PTFS-Europe · Jun 3, 2024 · 2bbd7b9 · 2bbd7b9
2 parents 0778aa2 + 5622960
commit 2bbd7b9
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 3 deletions.
diff --git a/code/web/interface/themes/responsive/CollectionSpotlight/horizontalCarousel.tpl b/code/web/interface/themes/responsive/CollectionSpotlight/horizontalCarousel.tpl
@@ -1,4 +1,4 @@
-<div role="tabpanel" aria-labelledby="spotlightTab{$list->id}" id="tab-{$wrapperId}"{if !empty($display) && $display == 'false'} style="display:none"{/if} class="titleScroller tab-pane{if !empty($active)} active{/if}{if !empty($collectionSpotlight) && $collectionSpotlight->coverSize == 'medium'} mediumScroller{/if}{if !empty($collectionSpotlight) && $collectionSpotlight->showRatings} scrollerWithRatings{/if}">
+<div role="tabpanel" aria-labelledby="spotlightTab{$list->id}" id="tab-{$wrapperId}"{if !empty($display) && $display == 'false'} style="display:none"{/if} class="titleScroller tab-pane{if !empty($active)} active{/if}{if !empty($collectionSpotlight) && $collectionSpotlight->coverSize == 'medium'} mediumScroller{/if}{if !empty($collectionSpotlight) && $collectionSpotlight->coverSize == 'small'} smallScroller{/if}{if !empty($collectionSpotlight) && $collectionSpotlight->showRatings} scrollerWithRatings{/if}">
 {if !empty($showCollectionSpotlightTitle)}
 	<div id="tab-{$wrapperId}Header" class="titleScrollerHeader">
 		{if !empty($showCollectionSpotlightTitle) && !empty($scrollerTitle)}
@@ -7,7 +7,7 @@
 	</div>
 {/if}
 <div class="jcarousel-wrapper horizontalCarouselSpotlightWrapper">
-	<div class="jcarousel horizontalCarouselSpotlight {if $collectionSpotlight->coverSize == 'medium'}mediumScroller{/if}" id="collectionSpotlightCarousel{$list->id}">
+	<div class="jcarousel horizontalCarouselSpotlight {if $collectionSpotlight->coverSize == 'medium'}mediumScroller{/if}{if $collectionSpotlight->coverSize == 'small'}smallScroller{/if}" id="collectionSpotlightCarousel{$list->id}">
 		<div class="loading">{translate text="Loading carousel items..." isPublicFacing=true }</div>
 	</div>
 

diff --git a/code/web/interface/themes/responsive/css-rtl/main.css b/code/web/interface/themes/responsive/css-rtl/main.css
diff --git a/code/web/interface/themes/responsive/css-rtl/title-scroller.less b/code/web/interface/themes/responsive/css-rtl/title-scroller.less
@@ -121,6 +121,14 @@
     right: 0;
     left: 0;
   }
+  .smallScroller {
+    .scrollerTitleCover{
+      width: auto;
+    }
+    .carouselScrollerTitle .carouselScrollerTitleImage {
+      height: 140px;
+    }
+  }
 }
 
 .moreLikeThisWrapper,.seriesWrapper {

diff --git a/code/web/interface/themes/responsive/css/main.css b/code/web/interface/themes/responsive/css/main.css
diff --git a/code/web/interface/themes/responsive/css/title-scroller.less b/code/web/interface/themes/responsive/css/title-scroller.less
@@ -121,6 +121,14 @@
     left: 0;
     right: 0;
   }
+  .smallScroller {
+    .scrollerTitleCover {
+      width: auto;
+    }
+    .carouselScrollerTitle .carouselScrollerTitleImage{
+      height: 140px;
+    }
+  }
 }
 
 .moreLikeThisWrapper,.seriesWrapper {

diff --git a/code/web/release_notes/24.06.00.MD b/code/web/release_notes/24.06.00.MD
@@ -128,10 +128,18 @@
 - Added new Documentation links to several settings pages (*MKD*)
 - Updates to default user roles: removed testing roles and a couple uncommonly used roles; updated role titles (*MKD*)
 
+
+//Pedro - PTFS
+### Other Updates
+- Fix display of 'small' covers in collection spotlights (*PA*)
+
 ## This release includes code contributions from
 - ByWater Solutions
   - Mark Noble (MDN)
   - Kirstin Kroeger (KK)
   - Kodi Lein (KL)
   - Liz Rea (LR)
-  - Morgan Daigneault (MKD)
+  - Morgan Daigneault (MKD)
+
+- PTFS-Europe
+  - Pedro Amorim (PA)