Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PSPDFKit 6.5 for Android #373

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Update to PSPDFKit 6.5 for Android #373

merged 2 commits into from
Jul 15, 2020

Conversation

davidschreiber
Copy link
Contributor

@davidschreiber davidschreiber commented Jul 15, 2020 •
edited
Loading

Details

This PR updates the wrapper to PSPDFKit 6.5 for Android. Furthermore, it removes the need for using a Maven password to download and integrate PSPDFKit, which is no longer needed.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@davidschreiber davidschreiber self-assigned this Jul 15, 2020
@davidschreiber davidschreiber merged commit a63f88f into master Jul 15, 2020
@davidschreiber davidschreiber deleted the davidschreiber/android-6.5-update branch July 15, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoric skoric skoric approved these changes

Assignees

@davidschreiber davidschreiber

Labels
Android READY TO REVIEW update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidschreiber @skoric