Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for PSPDFKit 9.5 for iOS #371

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Update for PSPDFKit 9.5 for iOS #371

merged 3 commits into from
Jul 14, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Jul 1, 2020 •
edited
Loading

⚠️ Only merge after PSPDFKit 9.5 for iOS is released ⚠️

Details

This PR updates for the upcoming PSPDFKit 9.5 release.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz added the iOS label Jul 1, 2020
@radazzouz radazzouz self-assigned this Jul 1, 2020
@radazzouz radazzouz changed the title Update for PSPDFKit 9.5 for iOS [WIP] Update for PSPDFKit 9.5 for iOS Jul 6, 2020
@radazzouz radazzouz force-pushed the rad/update-for-pspdfkit-9.5-for-ios branch from dad2f13 to 6cf5d49 Compare July 7, 2020 13:11
@radazzouz radazzouz changed the title [WIP] Update for PSPDFKit 9.5 for iOS Update for PSPDFKit 9.5 for iOS Jul 7, 2020
@radazzouz radazzouz requested a review from steviki July 7, 2020 14:44
steviki
steviki approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radazzouz radazzouz merged commit bb2dbe9 into master Jul 14, 2020
@radazzouz radazzouz deleted the rad/update-for-pspdfkit-9.5-for-ios branch July 14, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviki steviki steviki approved these changes

Assignees

@radazzouz radazzouz

Labels
iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radazzouz @steviki