Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge Instant Example from PSPDFKit Catalog to the NativeCatalog React Native project #362

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Bridge Instant Example from PSPDFKit Catalog to the NativeCatalog React Native project #362

merged 4 commits into from
Apr 15, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Mar 27, 2020 •
edited
Loading

Details

In this PR, we're bridging the Instant example from native PSPDFKit Catalog to the NativeCatalog React Native sample project.

recording

Acceptance Criteria

  • The newly added NativeCatalog example works on iOS and does not break the Android example.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz added the iOS label Mar 27, 2020
@radazzouz radazzouz self-assigned this Apr 3, 2020
steviki
steviki approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and everything works fine. Looks good to me!
And sorry for the late review!

@radazzouz @steviki
Apply suggestions from code review
319c6a8 
Co-Authored-By: Stefan Kieleithner <[email protected]>
irgendeinich
irgendeinich approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@irgendeinich irgendeinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Doesn't affect Android

@radazzouz radazzouz merged commit c00e086 into master Apr 15, 2020
@radazzouz radazzouz deleted the rad/add-instant-native-catalog-exampe branch April 15, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irgendeinich irgendeinich irgendeinich approved these changes

@steviki steviki steviki approved these changes

Assignees

@radazzouz radazzouz

Labels
iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radazzouz @irgendeinich @steviki