-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include uuid in annotation removed event #349
Conversation
@@ -57,6 +57,7 @@ public void dispatch(RCTEventEmitter rctEventEmitter) { | |||
annotationMap = new HashMap<>(); | |||
annotationMap.put("name", annotation.getName()); | |||
annotationMap.put("creatorName", annotation.getCreator()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On iOS, we are not including the creator's name when an annotation is deleted:
[annotationsJSON addObject:@{@"uuid" : annotation.uuid, @"name" : annotation.name ?: [NSNull null]}]; |
The change would be pretty trivial:
- [annotationsJSON addObject:@{@"uuid" : annotation.uuid, @"name" : annotation.name ?: [NSNull null]}];
+ [annotationsJSON addObject:@{@"uuid" : annotation.uuid, @"name" : annotation.name ?: [NSNull null], @"creatorName" : annotation.user ?: [NSNull null]}];
@davidschreiber can you please make this change in this PR? Otherwise, I can do it myself in the PR or a followup PR.
Pinging @nickwinder, as I am not sure what Windows does when an annotation is deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for making the iOS change, @irgendeinich!
For #283
Details
uuid
in the removed event.Acceptance Criteria
package.json
,package-lock.json
,samples/Catalog/package.json
, andsamples/NativeCatalog/package.json
(see example commit: 1bf805f).