Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump PSPDFKit for Android to Version 6.1 #337

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Bump PSPDFKit for Android to Version 6.1 #337

merged 2 commits into from
Jan 10, 2020

Conversation

irgendeinich
Copy link
Contributor

Details

Updates our PSPDFKit for Android dependency to 6.1.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@irgendeinich irgendeinich self-assigned this Dec 18, 2019
radazzouz
radazzouz approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Does not impact iOS.

@irgendeinich irgendeinich merged commit d426b7b into master Jan 10, 2020
@irgendeinich irgendeinich deleted the reinhard/android-6.1 branch January 10, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomassurin tomassurin tomassurin approved these changes

@radazzouz radazzouz radazzouz approved these changes

Assignees

@irgendeinich irgendeinich

Labels
Android READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irgendeinich @tomassurin @radazzouz