-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the iOS and Android Catalog for React Native 0.59.9 #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Not a huge fan of how the new examples with the view component look now, since we can't hijack the navigation bar anymore, as react-navigation
doesn't use a native UINavigationController
, but fakes the navigation UI. Too bad NavigatorIOS
got removed, which used the native navigation controller. But nothing we could do about at the moment, so this is good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, but the Android Catalog doesn't run with react-native 0.59 since the react-native-camera has dependency conflicts with react-native 0.59. Our wrapper it self works and doesn't require anymore changes to work.
Thanks @irgendeinich! I've labeled this PR with |
# Conflicts: # samples/Catalog/Catalog.ios.js
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, windows is still going to be lagging behind here. They'll be a migration in react-native-windows
at some point when they've reimplemented the backend in C++ to support more than just UWP. But we're stuck until that work is done.
So. LGTM
…ManagerConfig('RCTPSPDFKitView') instead Update testing project to use FlatList instead of ListView
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now all good from my side. Feel free to merge whenever you're ready.
Details:
IMPORTANT: I branched off of the reinhard/update-rn-0.59.0 branch as it already had some changes which were required for iOS.
TODO:
Acceptance Criteria:
package.json
,package-lock.json
, andsamples/Catalog/package.json
(see example commit: 1bf805f).