Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: Migrate to PSPDFKit 5.4.0 and Android X #168

Closed
wants to merge 8 commits into from

Conversation

irgendeinich
Copy link
Contributor

@irgendeinich irgendeinich commented Feb 8, 2019

This update the wrapper to use PSPDFKit 5.4.0 and migrates to AndroidX.

To make AndroidX work with react-native and any third party dependency still using the Android support library a gradle script that automatically rewrites all imports is provided.

⚠️ This implementation is very unoptimized, it goes line by line through all source files even the ones that already were migrated and creates a copy of them. This process should only run in full once and then only for changed files though it might still make the build time significantly longer. It might also cause unexpected changes to the behaviour of the app since it's just naively replacing any matching strings.

irgendeinich added 2 commits February 8, 2019 16:52
Update test suite to work again
Update imports to use AndroidX
Add gradle script to automatically update imports in all modules
@irgendeinich irgendeinich changed the title Experimental: Migrate to PSPDFKit 5.2.0 and Android X Experimental: Migrate to PSPDFKit 5.3.0 and Android X Mar 27, 2019
@steipete
Copy link
Contributor

steipete commented Apr 6, 2019

Looks like the 0.60 release of React Native will fully support AndroidX. facebook/react-native#23112

irgendeinich added 3 commits May 2, 2019 14:38
# Conflicts:
#	README.md
#	android/src/main/java/com/pspdfkit/react/ConfigurationAdapter.java
@irgendeinich irgendeinich changed the title Experimental: Migrate to PSPDFKit 5.3.0 and Android X Experimental: Migrate to PSPDFKit 5.4.0 and Android X May 28, 2019
@irgendeinich
Copy link
Contributor Author

This workaround is no longer required, we now have support with #263.

@erhard-pspdfkit erhard-pspdfkit deleted the reinhard/android-x-support branch November 21, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants