Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for PSPDFKit 8 for iOS #131

Merged
merged 4 commits into from
Oct 17, 2018
Merged

Update for PSPDFKit 8 for iOS #131

merged 4 commits into from
Oct 17, 2018

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Oct 1, 2018 •
edited
Loading

⚠️ Merge after PSPDFKit 8 stable is out ⚠️

What to Test:

  • The README is updated.
  • The Catalog app works great.
  • A newly created React Native app works with the integration steps from the README.
  • The Android integration is unaffected.
  • The Windows integration is unaffected.

@radazzouz radazzouz self-assigned this Oct 1, 2018
steviki and others added 4 commits October 10, 2018 13:43
@steviki
Use updated constant names
47c3b10
Update Readme
13cccf2
Update CocoaPods integration
fd21417
Remove (comment out) old sharing options
6ae5e06 
We will implement the new sharing configuration from PSPDFKit 8 in a follow up issue.
@radazzouz
Copy link
Contributor Author

Created https://github.com/PSPDFKit/react-native/issues/133 as a follow up issue to (re)implement sharing options after PSPDFKit 8 is released.

@radazzouz radazzouz changed the title [WIP] Update for PSPDFKit 8 for iOS Update for PSPDFKit 8 for iOS Oct 10, 2018
nickwinder
nickwinder approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@nickwinder nickwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows unaffected.

@radazzouz radazzouz merged commit 6587a25 into master Oct 17, 2018
@radazzouz radazzouz mentioned this pull request Oct 17, 2018
Merged
@radazzouz radazzouz deleted the ios-8.0 branch October 17, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviki steviki steviki approved these changes

@nickwinder nickwinder nickwinder approved these changes

@irgendeinich irgendeinich Awaiting requested review from irgendeinich

Assignees

@radazzouz radazzouz

Labels
enhancement iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radazzouz @steviki @nickwinder