Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated API for pageGrabberEnabled #49

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Remove deprecated API for pageGrabberEnabled #49

merged 2 commits into from
Jul 30, 2021

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Jul 30, 2021 •
edited
Loading

Details

This PR is a followup for #46, where we remove the now deprecated (since PSPDFKit 10.5 for iOS) pageGrabberEnabled configuration option.

Release Notes:

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json and plugin.xml(see example commit: 09d5c6b).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/PSPDFKit-Cordova/releases).
  • Locally, pull the latest master and publish (npm publish) the new release to npm.

@radazzouz radazzouz assigned steviki and radazzouz and unassigned steviki Jul 30, 2021
@radazzouz radazzouz requested a review from steviki July 30, 2021 14:27
@radazzouz radazzouz merged commit 05843b2 into master Jul 30, 2021
@radazzouz radazzouz deleted the rad/page-grabber branch July 30, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviki steviki steviki approved these changes

Assignees

@radazzouz radazzouz

Labels
enhancement New feature or request ios READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radazzouz @steviki