Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace two cmbtp_* vars with single cmbtp variable #48

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Replace two cmbtp_* vars with single cmbtp variable #48

merged 1 commit into from
Nov 21, 2016

Conversation

martinholmer
Copy link
Contributor

This pull request implements the solution suggested by Dan @feenberg to a problem discussed in taxcalc repo issue 1073. The use of the new puf.csv file generated by this taxdata pull request is demonstrated in taxcalc repo pull request 1077.

@MattHJensen @Amy-Xu @andersonfrailey

@andersonfrailey
Copy link
Collaborator

@martinholmer looks good to me. I can produce and distribute the new puf.csv when this is merged.

@Amy-Xu
Copy link
Member

Amy-Xu commented Nov 21, 2016

Great! Thanks Martin! Merging.

@Amy-Xu Amy-Xu merged commit 21c7287 into PSLmodels:master Nov 21, 2016
@martinholmer martinholmer deleted the add-cmbtp-var branch November 21, 2016 20:42
@martinholmer
Copy link
Contributor Author

@andersonfrailey said:

I can produce and distribute the new puf.csv when [#48] is merged.

Now that both #43 and #48 have been merged by @Amy-Xu, do you want to distribute the new puf.csv file? When using the master branch I generate a puf.csv file that looks like this:

$ ls -l puf-2016-11-21.csv
-rw-r--r--  1 mrh  staff  50953138 Nov 21 15:38 puf-2016-11-21.csv

$ ~/work/OSPC/csvvars puf-2016-11-21.csv | head
1 age_head
2 age_spouse
3 DSI
4 EIC
5 FLPDYR
6 f2441
7 f6251
8 MARS
9 MIDR
10 n24

$ ~/work/OSPC/csvvars puf-2016-11-21.csv | tail
72 cmbtp
73 e00200p
74 e00200s
75 e00900p
76 e00900s
77 e02100p
78 e02100s
79 nu13
80 elderly_dependent
81 nu05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants